Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: Task description is now localize client side #427

Merged
merged 5 commits into from
Dec 17, 2017
Merged

Add: Task description is now localize client side #427

merged 5 commits into from
Dec 17, 2017

Conversation

Vdauphin
Copy link
Owner

@Vdauphin Vdauphin commented Nov 10, 2017 •
edited
Loading

  • Add: Task description is now localize client side.

#400 (comment)

When merged this pull request will:

  • Task description title and icon title are localize accordingly to client language
  • btc_fnc_task_create create the task on server. When created (BIS_fnc_taskExists), now also, update the description (BIS_fnc_setTask) with the correct language of the client (So now, on a German dedicate server, English client and German client will have the correct localize description).
  • side mission update due to this new behavior

Todo :

  • replace by _taskID
  • btc intro disappear
  • test if hint is not show twice when more than one player is connected
  • test all side mission.
  • test final phase task.

Final test:

  • local
  • server

Screenshots
German dedicate server and French client:
107410_20171111000015_1

@Vdauphin Vdauphin added this to the 1.18 milestone Nov 10, 2017
@1kuemmel1
Copy link

Really great! 👍
I made a similar upgrade too. Just a bit different but the same results.

@Vdauphin
Copy link
Owner Author

Do not hesitate to share if you have a better solution :)

@1kuemmel1
Copy link

Do not hesitate to share if you have a better solution :)

Better ? I didn't think so 😄
But you've been right: here you can take a look Add-task_handling_client

@Vdauphin
Copy link
Owner Author

Vdauphin commented Nov 13, 2017 •
edited
Loading

I took a little look to your solution. I think my solution is a little simpler ^^ but thanks for the share!
My goal is to slowly leave BI handle task because BI task system is actually good and can handle multiple tasks at the same time (somebody asked me this feature, like multiple side mission etc).

@Vdauphin Vdauphin merged commit 95ec1af into master_daily Dec 17, 2017
@Vdauphin Vdauphin deleted the ADD-change_task branch December 26, 2017 14:29
@Vdauphin Vdauphin mentioned this pull request Mar 27, 2018
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.18
Development

Successfully merging this pull request may close these issues.
2 participants
@Vdauphin @1kuemmel1